Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set more lossy precision requirements #3726

Merged
merged 1 commit into from
Apr 30, 2024
Merged

test: set more lossy precision requirements #3726

merged 1 commit into from
Apr 30, 2024

Conversation

nahso
Copy link
Collaborator

@nahso nahso commented Apr 30, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Tests
    • Updated test cases to specify precision digits directly, enhancing the accuracy of model compression tests.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 30, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent modifications focus on enhancing test precision by introducing a precision_digit parameter for each test case in the dictionary. This change eliminates the need for a default precision function, streamlining the process by directly assigning precision values within the test methods.

Changes

File Change Summary
source/tests/tf/.../test_model_compression_se_atten.py Added precision_digit key-value pairs to test cases, removed _get_default_places function, and directly assigned precision values in test methods.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 49f17cc and 3116456.
Files selected for processing (1)
  • source/tests/tf/test_model_compression_se_atten.py (16 hunks)
Files skipped from review due to trivial changes (1)
  • source/tests/tf/test_model_compression_se_atten.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (49f17cc) to head (3116456).

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3726      +/-   ##
==========================================
- Coverage   82.15%   82.14%   -0.01%     
==========================================
  Files         511      511              
  Lines       47364    47364              
  Branches     2953     2953              
==========================================
- Hits        38910    38909       -1     
- Misses       7561     7562       +1     
  Partials      893      893

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm enabled auto-merge April 30, 2024 06:32
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Apr 30, 2024
Merged via the queue into deepmodeling:devel with commit ee47e75 Apr 30, 2024
60 checks passed
@njzjz njzjz added this to the v2.2.11 milestone Apr 30, 2024
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Jul 2, 2024
@nahso @njzjz
test: set more lossy precision requirements (deepmodeling#3726)
5510794 
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated test cases to specify precision digits directly, enhancing the
accuracy of model compression tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit ee47e75)
@njzjz njzjz mentioned this pull request Jul 2, 2024
Merged
njzjz pushed a commit that referenced this pull request Jul 3, 2024
@nahso @njzjz
test: set more lossy precision requirements (#3726)
446d2f0 
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated test cases to specify precision digits directly, enhancing the
accuracy of model compression tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit ee47e75)
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
@nahso
test: set more lossy precision requirements (deepmodeling#3726)
11bd81b 
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated test cases to specify precision digits directly, enhancing the
accuracy of model compression tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
v2.2.11
Development

Successfully merging this pull request may close these issues.
3 participants
@nahso @wanghan-iapcm @njzjz